-
-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETH send modal does not correspond with FW #9567
Comments
@Hannsek |
QA: please see Notes for QA in PR description #9716 |
QA NOK sent issues for different coins but ETH modal does not correspond with model S3 too. Info:
|
This should now "work" with TT only as there was a bug on TS3. Should be fixed by this and it should be in the next fw release. Please try it with current main fw. |
QA OK retested ETH flow again and it works as expected https://www.notion.so/satoshilabs/eth-send-flow-7e8280cb08e548b79d72ad70b7ea5d9d Info:
|
Problem statement
(look below for solution)
In FW (2.6.2) there are currently only 2 screens:
In Suite, there are 5 points.
I'd expect only 2 bullets:
In tokens there is additional Contract address screen:
Solution
Please update the Ethereum and Ethereum tokens send flow for T2B1 (all FWs) and T2T1 (only with FW 2.6.3 and later) as follows and align with the FW team to synchronize the FW<->Suite actions.
Reduce the steps in Ethereum send flow modal window from current 5 steps to only 3:
Important: The example in the Suite design in Figma above is including the Spaced address checking and in the design corresponding to T2T1. Please make sure to have the black frame contents in the format and design matching the device type, its firmware version and Spaced/Continuous address view setup in settings as described in T2B1 Segmented Address Checking#31
For Ethereum tokens, there's one extra step in the Send modal (and FW ofc) before all the other steps. Otherwise it should behave same as the Ethereum send flow described above.
Please note that all data in the design might be sort of gibberish, use real data, labels etc. as we did until now).
Nice to have: if the user would return a step in FW, the modal should ideally return as well to help users checking the contents in the best focus.
The text was updated successfully, but these errors were encountered: