Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETH send modal does not correspond with FW #9567

Closed
Tracked by #9656
Hannsek opened this issue Oct 2, 2023 · 5 comments · Fixed by #9716
Closed
Tracked by #9656

ETH send modal does not correspond with FW #9567

Hannsek opened this issue Oct 2, 2023 · 5 comments · Fixed by #9716
Assignees
Labels
altcoins not related to bitcoin release Will be included in the upcoming release. Needs to be backported to the release branch. send Send page

Comments

@Hannsek
Copy link
Contributor

Hannsek commented Oct 2, 2023

Problem statement

(look below for solution)

image

In FW (2.6.2) there are currently only 2 screens:
image

In Suite, there are 5 points.

I'd expect only 2 bullets:

  • Receipient
  • Amount | Maximum fee

In tokens there is additional Contract address screen:
image

  • when I press the back arrow in fw, bullets keeps checking one by one. I'd expect the bullet to uncheck when I go back in fw. (not sure if this is possible; are we differentiating between "confirm" and "back" message in fw? @mmilata)

Solution

Please update the Ethereum and Ethereum tokens send flow for T2B1 (all FWs) and T2T1 (only with FW 2.6.3 and later) as follows and align with the FW team to synchronize the FW<->Suite actions.

Reduce the steps in Ethereum send flow modal window from current 5 steps to only 3:

  1. Recipient address match? (Figma design)
  2. Amount & Maximum fee matching? (Figma design)
  3. All confirmed, send (Figma design)

Important: The example in the Suite design in Figma above is including the Spaced address checking and in the design corresponding to T2T1. Please make sure to have the black frame contents in the format and design matching the device type, its firmware version and Spaced/Continuous address view setup in settings as described in T2B1 Segmented Address Checking#31

For Ethereum tokens, there's one extra step in the Send modal (and FW ofc) before all the other steps. Otherwise it should behave same as the Ethereum send flow described above.

Please note that all data in the design might be sort of gibberish, use real data, labels etc. as we did until now).

Nice to have: if the user would return a step in FW, the modal should ideally return as well to help users checking the contents in the best focus.

@Hannsek Hannsek added send Send page altcoins not related to bitcoin labels Oct 2, 2023
@matejkriz
Copy link
Member

matejkriz commented Oct 9, 2023

@Hannsek isn't it already in 2.6.0?
nope

@matejkriz matejkriz moved this to 🎯 To do in Issues Suite Oct 10, 2023
@matejkriz matejkriz added the release Will be included in the upcoming release. Needs to be backported to the release branch. label Oct 23, 2023
@matejkriz matejkriz moved this from 🎯 To do to 🏃‍♀️ In progress in Issues Suite Oct 25, 2023
@matejkriz
Copy link
Member

matejkriz commented Oct 31, 2023

QA: please see Notes for QA in PR description #9716

@github-project-automation github-project-automation bot moved this from 🏃‍♀️ In progress to 🤝 Needs QA in Issues Suite Oct 31, 2023
@bosomt
Copy link
Contributor

bosomt commented Nov 16, 2023

QA NOK

sent issues for different coins but ETH modal does not correspond with model S3 too.
Device asks you to confirm amount but modal is still focused on address even it was already confirmed

telegram-cloud-photo-size-4-5958666962106170901-y

Info:

  • Suite version: desktop 23.11.3 (71b8305)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.11.3 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: Trezor T2B1 2.6.3 regular (revision 2c7cc6e0255dee2339b445b5551eaffb88dbd1b4)
  • Transport: BridgeTransport 2.0.33

@Hannsek
Copy link
Contributor Author

Hannsek commented Nov 16, 2023

This should now "work" with TT only as there was a bug on TS3. Should be fixed by this and it should be in the next fw release. Please try it with current main fw.

@bosomt
Copy link
Contributor

bosomt commented Nov 17, 2023

QA OK

retested ETH flow again and it works as expected

https://www.notion.so/satoshilabs/eth-send-flow-7e8280cb08e548b79d72ad70b7ea5d9d

Info:

  • Suite version: desktop 23.11.3 (71b8305)
  • Browser: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) TrezorSuite/23.11.3 Chrome/118.0.5993.129 Electron/27.0.4 Safari/537.36
  • OS: MacIntel
  • Screen: 1440x900
  • Device: Trezor T2T1 2.6.3 regular (revision 2c7cc6e0255dee2339b445b5551eaffb88dbd1b4)
  • Transport: BridgeTransport 2.0.33

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Issues Suite Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
altcoins not related to bitcoin release Will be included in the upcoming release. Needs to be backported to the release branch. send Send page
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants