Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug/playground #1735

Open
wants to merge 2 commits into
base: v5-candidate
Choose a base branch
from
Open

debug/playground #1735

wants to merge 2 commits into from

Conversation

signatenkov
Copy link
Contributor

Type of PR: enhancement

as discussed I moved playground into debug folder on v5-candidate

Old PR: #1732

Copy link

github-actions bot commented Nov 18, 2024

size-limit report 📦

Path Size
ESM 42.31 KB (0%)
ESM createChart 36.27 KB (0%)
ESM createChartEx 35.06 KB (0%)
ESM Standalone 43.82 KB (0%)
Standalone 43.75 KB (0%)
Plugin: Text Watermark 1.86 KB (0%)
Plugin: Image Watermark 1.68 KB (0%)
Plugin: Series Markers 3.89 KB (0%)
Series: LineSeries 2.54 KB (0%)
Series: BaselineSeries 3.05 KB (0%)
Series: AreaSeries 2.98 KB (0%)
Series: BarSeries 2.14 KB (0%)
Series: CandlestickSeries 2.43 KB (0%)
Series: HistogramSeries 2.2 KB (0%)

@signatenkov signatenkov marked this pull request as ready for review November 18, 2024 19:56
@signatenkov signatenkov self-assigned this Nov 18, 2024
@signatenkov
Copy link
Contributor Author

@SlicedSilver make it in v5-candidate

@SlicedSilver
Copy link
Contributor

I think we could simplify this by doing the following:

  • specify lightweight-charts within the package.json like this: "lightweight-charts": "file:../.." so that we don't need to use npm link
  • change the dev script in the package.json to "dev": "vite",
  • remove the playground.sh file
  • move debug/playground/wwwroot/* to debug/playground/ (so we don't need the wwwroot folder)

We have actually got something similar in the plugins-examples folder (we can skip the building part).


Anyway, this approach is probably nicer than the esm files in the debug folder. So perhaps you could move all of these playground files into the debug folder itself but still keep the debug-standalone.html file (because it would still be useful to test with the standalone build as well).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants