-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[general] Prevent api change #467
base: releaseCandidate
Are you sure you want to change the base?
[general] Prevent api change #467
Conversation
…alesforce-Inspector-reloaded into preventApiChange
Hi @hakeemsalman, If the user did not visited the Org tab he can't update the api version: Today the apiVersion setting is not org specific and it can be an issue since the latest api version is not always the same depending on the environment you are. Let me expose how I see it:
chrome.runtime.onInstalled.addListener(({reason}) => {
if (reason === "install") {
chrome.tabs.create({
url: "https://tprouvot.github.io/Salesforce-Inspector-reloaded/welcome/"
});
} else if (reason === "update") {
//delete localStorage 'apiVersion' which is not used anymore and became org specific
localStorage.removeItem("apiVersion");
}
}); |
Hi @hakeemsalman, |
Hi @tprouvot, I apologize for the late response. I was busy with work and learning this Chrome extension and code. I appreciate your feedback and will address the issues as soon as possible. I am still in the learning stage and eager to improve. Thank you for your understanding. Best regards, |
Hi @tprouvot, I hope you're doing well. Thank you for your patience. I’ve been focused on learning and refining the code. I've been in learning the React.js and I'm making progress. I'm currently working on understanding and fixing the issues you mentioned. I’ve made progress on the input max attribute issue as described. However, I need a bit more clarification on implementing the API storage and session settings. Specifically, could you please provide more details or hints on how to properly store the API data when the popup opens and the session settings are not populated? I’d like to understand better how to trigger the API call for the org tab and use the stored settings efficiently. Any additional explanation or examples would be very helpful. Thank you for your continued support. Best regards, |
You can check the request made on Organization to store the isSandbox local property, basically you do the same query that is made on the orgTab and store the result in a session storage |
Thank you for giving the inputs. I will work on that and update the status. |
Describe your changes
#464 issue number and LINK
Checklist before requesting a review