Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User-defined markers #116

Open
2 of 5 tasks
tonyc opened this issue May 8, 2023 · 7 comments
Open
2 of 5 tasks

User-defined markers #116

tonyc opened this issue May 8, 2023 · 7 comments
Assignees
Milestone

Comments

@tonyc
Copy link
Owner

tonyc commented May 8, 2023

Have the ability to create/place a marker on the spectrum scope, through keyboard and also through a UI button click.

Also have the ability to remove a specific marker, or clear all markers at once.

The markers should be associated to the connection, and persist across restarts.

  • Ability to drop a markers via keyboard shortcut
  • Ability to clear markers via a keyboard shortcut
  • Marker persistence
  • Ability to jump between markers in frequency order (UI/keyboard)
  • Some sort of UI/button scheme for everything
@tonyc tonyc added this to the 1.1.0 milestone May 8, 2023
@tonyc tonyc self-assigned this May 8, 2023
@tonyc
Copy link
Owner Author

tonyc commented May 17, 2023

This has landed in develop, with a couple of caveats:

  • Markers are not yet persisted across page reloads or connection restarts
  • Keyboard controls only (no UI yet) - mm, mr / mg / mb to drop white/red/green/blue markers, and cc / cr / cg / cb to clear white/red/green/blue markers.

@Tyrbiter
Copy link

Hi Tony

Using Firefox 113 on Fedora, put mouse cursor over spectrum display, tap m and immediately the search box opens with the M of MIC highlighted.

@tonyc
Copy link
Owner Author

tonyc commented May 17, 2023

Hmm, do you have the "Search for text when you start typing" option turned on? I can look into seeing if there's a way to disable it on the client-side in JS.

@tonyc
Copy link
Owner Author

tonyc commented May 17, 2023

Also to note, you don't necessarily need to have the mouse cursor hovering over the spectrum - the keyboard shortcuts will currently drop the marker at the left-side VFO location, not where the mouse is pointing.

@Tyrbiter
Copy link

Yes, I had that selected, although I don't remember doing it so maybe it was a default I've never changed.

So if the cursor is over the spectrum it should drop the marker where the cursor is or have you not implemented that yet?

In any case I now get markers, I will wait for development to get it all sorted out.

@tonyc
Copy link
Owner Author

tonyc commented May 17, 2023

So if the cursor is over the spectrum it should drop the marker where the cursor is or have you not implemented that yet?

I haven't decided on this interaction yet, but it seems like a reasonable way to expect it to behave!

@Tyrbiter
Copy link

It looks like being a useful feature. Perhaps you could also have a list of fixed markers that are always present, a bit like the macros in config.toml and user configurable. Marking frequencies for unusual modes is the application I'm thinking of, like the freedv frequencies for instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants