Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.4 support #16

Open
pdonorio opened this issue Feb 22, 2018 · 1 comment
Open

Python 3.4 support #16

pdonorio opened this issue Feb 22, 2018 · 1 comment

Comments

@pdonorio
Copy link

Hi,
Python 3.4 seems not supported as I read stated:

Syntax-highlighting, declarative and composable pretty printer for Python 3.5+

Is there any particular reason behind it?
I really like your project and willing to help adding that support
since we have to support Python 3.4+ in all of our projects and this library could break our compatibility.

Thanks for your work

@tommikaikkonen
Copy link
Owner

Thanks! No particular reason, on Python 3 I've only worked with 3.5 and 3.6, so initially I wrote the library to support just 3.6. I recently added support for 3.5. With that change, the test suite is ran against multiple Python versions (3.6 and 3.5). 3.4 would be easy to add there from the tox config.

I think the test coverage is pretty good, so I'll gladly accept a PR that supports 3.4 and passes tests on all 3.4, 3.5 and 3.6 on the CI I've set up on this repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants