Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When overriding with a URL (using --licenseurl-to-license-mappings), the result should be an expression #190

Open
danielo-unity3d opened this issue Jun 14, 2023 · 1 comment

Comments

@danielo-unity3d
Copy link

The readme says this about the --licenseurl-to-license-mappings command-line flags:

When used, this option allows to override the url to license mapping built into the application (see [here](src/NuGetUtility/LicenseValidator/UrlToLicenseMapping.cs))

but the default array of conversions (Uri to string) implies that the resulting license (or LicenseValidationResult) should convert the origin type from LicenseInformationOrigin.Url to LicenseInformationOrigin.Expression), since it has been mapped.

@sensslen
Copy link
Collaborator

Hi @danielo-unity3d can you please specify which version of the tool you are running?

Assuming from your comment that you are using the 3.0.0-alpha.* version.

The main reason this does specify LicenseInformationOrigin.Url is because the license was given as URL (The Origin of the license is a URL). This is an important information, as URL's can change it's content and also go offline. This is the main reason Microsoft deprecated the License URL files in the NuGet specification.

Please feel free to create a PR if you feel the documentation can be improved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants