Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests in FiniteSetsExtTests rely on specific line numbers #48

Open
will62794 opened this issue Sep 12, 2021 · 1 comment
Open

Unit tests in FiniteSetsExtTests rely on specific line numbers #48

will62794 opened this issue Sep 12, 2021 · 1 comment

Comments

@will62794
Copy link
Contributor

These unit tests in FiniteSetsExtTests rely on specific line numbers of statements in the FiniteSetsExt.tla module. So, if one tries to modify FiniteSetsExt.tla in a way that shifts existing statements to different line numbers, it breaks these tests. These tests should be updated to avoid dependence on specific line numbers.

@lemmy
Copy link
Member

lemmy commented Sep 12, 2021

This is not limited to FiniteSetsExtTests but how most tests are written. The second paragraph in https://github.com/tlaplus/CommunityModules#contributing also warns about this. A workaround is to only append tests to an existing test module. I suggest this be added to https://github.com/tlaplus/CommunityModules#contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants