Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git_resource extension makes bad assumptions about repo url #618

Open
CafeLungo opened this issue Nov 22, 2024 · 0 comments
Open

git_resource extension makes bad assumptions about repo url #618

CafeLungo opened this issue Nov 22, 2024 · 0 comments

Comments

@CafeLungo
Copy link

The git_resource plugin assumes the protocol is ssh, and it also assumes the ssh port is 22. This does not work if your git server is using a different port. It is also incompatible with the protocol portion of the URL. For example git+ssh://myurl.com:2222/my_repo.git is not identified as a URL, but instead as a directory:

Use case: git+ssh://myurl.com:2222/my_repo.git:
Actual result:
It assumes this is a directory:

Error in docker_build: error reading dockerfile: open /Users/user/Documents/workspace/my_project/git+ssh:/[email protected]:2222/my_repo.git/Dockerfile:

Expected result:
Cloning into /Users/user/Library/Application Support/tilt-dev/.git-sources/my_repo from git+ssh://myurl.com:2222

Use case: myurl.com:2222/my_repo.git:
Actual result:
It makes assumptions about the ssh server:

cloning into '/Users/user/Library/Application Support/tilt-dev/.git-sources/my_repo'...
ssh: connect to host myurl.com port 22: Operation timed out

Expected result:
Cloning into /Users/user/Library/Application Support/tilt-dev/.git-sources/my_repo from git+ssh://myurl.com:2222/my_repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant