-
Notifications
You must be signed in to change notification settings - Fork 342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_html_live() memory "leak" #408
Comments
If you |
I'll do that, thanks. |
Just want to add my own experience. page$session$close() |
@rcepka can you provide any more details? |
Closing this because without a reprex, unfortunately there's nothing I can do. |
I'm experimenting with read_html_live() using Vivaldi as the headless browser (I try to avoid installing Google Chrome).
It works great. But, I've noticed that it's leaving some Chromate cruft behind. Each time I run my R script, the macOS activity monitor shows a new instance of the "Vivaldi Helper (Renderer)" that costs about 500 MB of memory and actually grows from there. Run the script too many times, and, naturally the whole computer grinds to a halt. When I force-kill the processes in the activity monitor, the R console report "[error] handle_read_frame error: websocketpp.transport:7 (End of File)"
I'm not sure if I'm missing some kind of clean-up step, or if this is a Vivaldi problem, of if this is an rvest bug, but wanted to let you know, @hadley.
Later:
I've noticed that pairing
payload <- rvest::read_html_live(url)
withpayload$session$close()
addresses the problem I'm describing (i.e., the "Vivaldi Helper (Renderer)" disappears from he Activity Monitor). Apologies if I missed the need for doing this in the docs.The text was updated successfully, but these errors were encountered: