Include R6 as Suggests?

[MichaelChirico]

R6 is a build-time dependency of rvest, e.g.

rvest/R/text.R

Line 189 in 8e19075

PaddedText <- R6::R6Class("PaddedText", list(

This is a place where R's dependency system is a bit lacking in detail. AIUI CRAN rules don't specify anything about declaring build-time dependencies, and I haven't seen anything in WRE that describes rules either. See also RcppCore/Rcpp#1254.

So I don't think there's any rule saying 'R6' needs to be mentioned in the DESCRIPTION; nor is there any tooling to help make sure this list is up-to-date*. But still I think it's good practice that R6 should be mentioned somewhere in DESCRIPTION. I think the most natural place to do so is in 'Suggests'.

*That's not quite true. The reason I discovered this is with an extended version of R CMD check I wrote that runs tools:::.check_packages_used(dir = pkg_dir), which will flag the usage (but not surface it in R CMD check, not sure why)

[hadley]

It is? https://github.com/tidyverse/rvest/blob/chromote/DESCRIPTION#L30

[hadley]

Ooops, it is in that branch