-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix td translations #1545
Fix td translations #1545
Conversation
Ajout d'un argument pour le nombre chars Par défaut 255 Corrige le bug
Hello, I had opened this PR by mistake while trying to open a PR elsewhere, and since it happened before anyone gave me the permission on my issue I felt like I was being very impolite so I closed it until someone gave me the green light :) |
Modified the test for as.double Modified and added a new test for as.character
Hi, I'm just checking in to ask if I forgot something here ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I'm just checking in to ask if I forgot something here ?
Nope, all good! Just took me a bit to get to it.
These changes look solid to me. I'm approving merge, but going to ping another reviewer internally before doing so.
Co-authored-by: Simon P. Couch <[email protected]>
Hello, I hope I clicked in the right places ! |
Fixed as.character and as.double for Teradata