Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add helper function for try(rlang::eval_tidy(cl), silent = TRUE) #1386

Open
EmilHvitfeldt opened this issue Oct 22, 2024 · 2 comments
Open

Comments

@EmilHvitfeldt
Copy link
Member

          I think it will be worth it to have a helper function here. Using the above code for helping. There are many places in {recipes} where we `try(rlang::eval_tidy(cl), silent = TRUE)` and it smells a little like we need a helper function

Originally posted by @EmilHvitfeldt in #1383 (comment)

@simonpcouch
Copy link
Contributor

Another bit that feels worth mentioning is that many usages of this pattern in this package call as.character() on the condition object rather than just passing the condition to the parent argument.

@EmilHvitfeldt
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants