Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uefi-sct/SctPkg: ExtractConfig allows EFI_ACCESS_DENIED with a warning #110

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

anncheng-arm
Copy link

@anncheng-arm anncheng-arm commented Nov 14, 2024

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4847

EFI_ACCESS_DENIED (The action violated a system policy) is an acceptable status for ExtractConfig in UEFI specification.
SCT now marks the test case as a warning instead of failure, when EFI_ACCESS_DENIED is returned.

Build pass verified locally with #105

Signed-off-by: Ann Cheng [email protected]

@anncheng-arm
Copy link
Author

@edhay @sunnywang-arm , please kindly review

@anncheng-arm anncheng-arm force-pushed the dev/fix_extractconfig_return_status branch 4 times, most recently from 04557b2 to 272ca69 Compare November 14, 2024 15:55
@anncheng-arm
Copy link
Author

reupdate commit to fix issues that identify by PatchCheck.py

python ../edk2/BaseTools/Scripts/PatchCheck.py -1
Checking git commit: 272ca69
uefi-sct/SctPkg: ExtractConfig allows EFI_ACCESS_DENIED with a warning
The commit message format passed all checks.
The code passed all checks.
The commit adds/modifies files in multiple packages:

  • uefi-sct/SctPkg/SctPkg.dec
  • uefi-sct/SctPkg/UEFI/UEFI.dec

@sunnywang-arm
Copy link
Contributor

Looks good to me.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4847

EFI_ACCESS_DENIED (The action violated a system policy)
is an acceptable status for ExtractConfig in UEFI specification.

SCT now marks the test case as a warning instead of failure,
when EFI_ACCESS_DENIED is returned.

Cc: G Edhaya Chandran <[email protected]>
Cc: Barton Gao <[email protected]>
Cc: Carolyn Gjertsen <[email protected]>
Signed-off-by: Ann Cheng <[email protected]>
@anncheng-arm anncheng-arm force-pushed the dev/fix_extractconfig_return_status branch from 272ca69 to 7a0f103 Compare November 15, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants