Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non unique uid entrypoint #77

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

osteffenrh
Copy link
Contributor

Description

Allow non-unique/already existing user ID in the entrypoint script.
This makes it possible to use the image as root or with Podman

Issue #76

Containers Affected

All dev images.

@osteffenrh
Copy link
Contributor Author

Oh, this one has been sitting here for a while. I forgot...

@osteffenrh osteffenrh self-assigned this Nov 27, 2023
Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

This should fix tianocore#76

Signed-off-by: Oliver Steffen <[email protected]>
@osteffenrh osteffenrh mentioned this pull request Dec 6, 2023
osteffenrh added a commit to osteffenrh/edk2-containers that referenced this pull request Dec 6, 2023
Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

See issue tianocore#76 and PR tianocore#77.

Signed-off-by: Oliver Steffen <[email protected]>
@osteffenrh osteffenrh mentioned this pull request Dec 6, 2023
osteffenrh added a commit to osteffenrh/edk2-containers that referenced this pull request Dec 6, 2023
Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

See issue tianocore#76 and PR tianocore#77.

Signed-off-by: Oliver Steffen <[email protected]>
osteffenrh added a commit that referenced this pull request Dec 8, 2023
* Fedora 39: Use Qemu from package repo

Fedora 39 ships Qemu 8. We can use that instead of building it from
source.

Also add Qemu for RiscV.

Signed-off-by: Oliver Steffen <[email protected]>

* Allow using dev image as root

Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

See issue #76 and PR #77.

Signed-off-by: Oliver Steffen <[email protected]>

* Readme: Add Fedora 39 image to table

Add links and badges for the Fedora 39 images to the table.

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Oliver Steffen <[email protected]>
mairudiF added a commit to mairudiF/containers that referenced this pull request Mar 2, 2024
* Add Fedora 39 image with gcc13 (tianocore#82)

Added Fedora 39 base image, providing GCC13 and Python 3.12.

Signed-off-by: Chao Li <[email protected]>

* Fedora 39 fixups (tianocore#87)

* Fedora 39: Use Qemu from package repo

Fedora 39 ships Qemu 8. We can use that instead of building it from
source.

Also add Qemu for RiscV.

Signed-off-by: Oliver Steffen <[email protected]>

* Allow using dev image as root

Don't abort the entrypoint script if the user-id already exists.
This allows using the dev images as root or when using Podman,
which does some user mapping already.

See issue tianocore#76 and PR tianocore#77.

Signed-off-by: Oliver Steffen <[email protected]>

* Readme: Add Fedora 39 image to table

Add links and badges for the Fedora 39 images to the table.

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Oliver Steffen <[email protected]>

* Fedora 39 Build Fixes (tianocore#88)

* Fedora39: Don't use fixed package versions

Specifying version numbers for the packages provided by the Linux
distribution is counterproductive. The available patchlevel versions of a
package can change within a Fedora release. This can breaks image builds
which requires additional manual work. Since the major versions stay
fixed, there should not be any compatibility issues between image
builds. Additionally, bug fixes are picked up automatically.

This patch removes the explicit version numbers from the packages and
installs the default versions instead.

Signed-off-by: Oliver Steffen <[email protected]>

* Fedora 39: Install python-setuptools via pip

Install python-setuptools via pip instead of taking it from the Fedora
repo. This avoids possible conflicts with `pip install --upgrade ...`

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Oliver Steffen <[email protected]>

---------

Signed-off-by: Chao Li <[email protected]>
Signed-off-by: Oliver Steffen <[email protected]>
Co-authored-by: Chao Li <[email protected]>
Co-authored-by: Oliver Steffen <[email protected]>
@ghost
Copy link

ghost commented May 24, 2024

It looks like this needs some changes since for example the Fedora 35 container was removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant