Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epilogue lambda guards #67

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

imShZh
Copy link
Contributor

@imShZh imShZh commented Nov 22, 2024

The guard manager in torch.compile not only includes RootGuardManager, but also contains epilogue lambda guards. Checkout this link for more details.

This PR adds the missing guards in depyf, and change some ambiguous variable name to prevent possible future mistakes.

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great fix!

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.69%. Comparing base (2ba8467) to head (9286d9c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
depyf/explain/utils.py 92.85% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
+ Coverage   90.66%   90.69%   +0.03%     
==========================================
  Files          10       10              
  Lines        1542     1547       +5     
==========================================
+ Hits         1398     1403       +5     
  Misses        144      144              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@youkaichao youkaichao merged commit cbfbc00 into thuml:master Nov 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants