Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a bug in checking wrong object's type #66

Merged
merged 2 commits into from
Nov 24, 2024

Conversation

imShZh
Copy link
Contributor

@imShZh imShZh commented Nov 22, 2024

The variable guard is always a list object. We should check leaf guard(i.e., variable x)'s type here.

@imShZh imShZh changed the title fix bugs in checking wrong object's type fix a bug in checking wrong object's type Nov 22, 2024
@youkaichao
Copy link
Member

is this still necessary after #67 ?

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.88%. Comparing base (cbfbc00) to head (2b0a3e6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   90.82%   90.88%   +0.06%     
==========================================
  Files          10       10              
  Lines        1547     1547              
==========================================
+ Hits         1405     1406       +1     
+ Misses        142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@imShZh
Copy link
Contributor Author

imShZh commented Nov 23, 2024

is this still necessary after #67 ?

Yes, the other PR does not introduce this modification, as it may not what you want.

PTAL~

Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thank for fixing it!

@youkaichao youkaichao merged commit 2acfd19 into thuml:master Nov 24, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants