Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename docs/adr default directory to docs/decisions to improve usage #12

Open
thomvaill opened this issue Dec 16, 2020 · 6 comments · May be fixed by #98
Open

Rename docs/adr default directory to docs/decisions to improve usage #12

thomvaill opened this issue Dec 16, 2020 · 6 comments · May be fixed by #98
Labels
feature New feature or request good first issue Good for newcomers next

Comments

@thomvaill
Copy link
Owner

Feature Request

Feature Suggestion

For now, the default directory for ADRs is docs/adr, because it was commonly documented like this:

But @joelparkerhenderson recently gave me this interesting feedback:

Some teams much prefer the name "decisions" over the abbreviation "ADRs". When some teams use the directory name "decisions", then it's as if a light bulb turns on, and the team starts putting more information inton the directory, such as vendor decisions, planning decisions, scheduling decisions, etc. All of these kinds of information can use the same template. We hypothesize that people learn faster with words ("decisions") over abbreviations ("ADRs"), and people are more motivated to write work-in-progress docs when the word "record" is removed, and also some developers and some managers dislike the word "architecture".

So I propose to change the default value in Log4brains, because I am convinced that ADRs should not be reserved only for important architectural decisions. They are also beneficial for all kind of decisions, and we should promote that.

Possible Implementation

  • Search and replace all occurrences of docs/adr in the README
  • Search and replace all occurrences of docs/adr in the code, only when it is used as a default value
  • Create an ADR for this :-)
@thomvaill thomvaill added feature New feature or request good first issue Good for newcomers labels Dec 16, 2020
@thomvaill thomvaill changed the title Rename adr directory to decisions Rename docs/adr default directory to docs/decisions to improve usage Dec 16, 2020
@fire
Copy link

fire commented May 2, 2021

What's the status of this?

I personally think that "decisions" is more immediately understandable than "adr".

@thomvaill
Copy link
Owner Author

I agree too.
I'll make the change in the next version.
Or if someone wants to contribute, PRs are welcome :-)

@thomvaill thomvaill added the next label May 2, 2021
@fire
Copy link

fire commented May 24, 2021

Should log4brains adr new have an alias for log4brains decision new?

@cabello
Copy link

cabello commented Sep 8, 2021

I just tried implementing this, there are over 2200 mentions of ADR in the repo, some of them are non-obvious to replace, for the time being I renamed my folder and changed the adrFolder as the project is configurable.

One minor but eventually "bike sheddable" discussion is singular vs plural, the project is consistent right now with all singular, by having docs/decisions and log4brains decision new, thing could get confusing, maybe a command alias would be welcomed in this case.

tylerhubert added a commit to tylerhubert/log4brains that referenced this issue Jan 20, 2023
@tylerhubert tylerhubert linked a pull request Jan 20, 2023 that will close this issue
@tylerhubert
Copy link

I've taken a stab at updating this in #98. Please feel free to provide feedback.

@joelparkerhenderson
Copy link

@tylerhubert Looks great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request good first issue Good for newcomers next
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants