Skip to content

Commit

Permalink
Deploying to gh-pages from @ 2ce51a4 🚀
Browse files Browse the repository at this point in the history
  • Loading branch information
thomvaill committed Oct 29, 2024
1 parent 68deaea commit 8890e25
Show file tree
Hide file tree
Showing 45 changed files with 42 additions and 42 deletions.
2 changes: 1 addition & 1 deletion adr/404.html

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion adr/404/index.html

Large diffs are not rendered by default.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions adr/adr/20200927-avoid-default-exports/index.html

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions adr/adr/20201016-use-the-adr-slug-as-its-unique-id/index.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions adr/adr/20201103-use-lunr-for-search/index.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions adr/adr/20240926-transition-to-simplified-git-flow/index.html

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions adr/adr/web/20200927-avoid-react-fc-type/index.html
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html><html lang="en"><head><meta name="theme-color" content="#2176AE"/><link rel="preconnect" href="https://fonts.gstatic.com"/><link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500;700&amp;display=swap"/><link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto+Slab:wght@300;400;500;700&amp;display=swap"/><meta charSet="utf-8"/><meta name="viewport" content="minimum-scale=1, initial-scale=1, width=device-width"/><link rel="shortcut icon" type="image/x-icon" href="/log4brains/adr/favicon.ico"/><meta name="og:image" content="/log4brains/adr/l4b-static/Log4brains-og.png"/><title>Avoid React.FC type ADR - Architecture knowledge base of Log4brains</title><meta name="next-head-count" content="5"/><link rel="preload" href="/log4brains/adr/_next/static/css/8b7db44cb7cb8e111c62.css" as="style"/><link rel="stylesheet" href="/log4brains/adr/_next/static/css/8b7db44cb7cb8e111c62.css" data-n-g=""/><noscript data-n-css=""></noscript><link rel="preload" href="/log4brains/adr/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/framework.5ab3178105b977ab7f59.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/commons.c5086e38f95c2aac1a1d.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/main-319220bbc2fa7828d1ea.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/a3e17150ead73d62fba7a33a50672ae3f72841a5.c9a32843ecac6aa7ca03.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/pages/_app-2c237ed8c06376e5e154.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/858546a3.952caa2a5f1090446743.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/580d9fe8.453754220469d52ed050.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/d4b94cf0.b6182e23194ff5c5e218.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/7ede4f97.b879b9f12f9bd2413581.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/45d2d314fc8da5e3d79852782e4a432ad4da6771.631b173fe0f55dca7e34.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/pages/adr/%5B...slug%5D-e208c392dc1424fbafe8.js" as="script"/><style id="jss-server-side">html {
<!DOCTYPE html><html lang="en"><head><meta name="theme-color" content="#2176AE"/><link rel="preconnect" href="https://fonts.gstatic.com"/><link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto:wght@300;400;500;700&amp;display=swap"/><link rel="stylesheet" data-href="https://fonts.googleapis.com/css2?family=Roboto+Slab:wght@300;400;500;700&amp;display=swap"/><meta charSet="utf-8"/><meta name="viewport" content="minimum-scale=1, initial-scale=1, width=device-width"/><link rel="shortcut icon" type="image/x-icon" href="/log4brains/adr/favicon.ico"/><meta name="og:image" content="/log4brains/adr/l4b-static/Log4brains-og.png"/><title>Avoid React.FC type ADR - Architecture knowledge base of Log4brains</title><meta name="next-head-count" content="5"/><link rel="preload" href="/log4brains/adr/_next/static/css/8b7db44cb7cb8e111c62.css" as="style"/><link rel="stylesheet" href="/log4brains/adr/_next/static/css/8b7db44cb7cb8e111c62.css" data-n-g=""/><noscript data-n-css=""></noscript><link rel="preload" href="/log4brains/adr/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/framework.5ab3178105b977ab7f59.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/commons.c5086e38f95c2aac1a1d.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/main-319220bbc2fa7828d1ea.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/a3e17150ead73d62fba7a33a50672ae3f72841a5.c9a32843ecac6aa7ca03.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/pages/_app-2c237ed8c06376e5e154.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/858546a3.952caa2a5f1090446743.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/580d9fe8.453754220469d52ed050.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/d4b94cf0.b6182e23194ff5c5e218.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/7ede4f97.b879b9f12f9bd2413581.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/45d2d314fc8da5e3d79852782e4a432ad4da6771.982bb88915300587cd0e.js" as="script"/><link rel="preload" href="/log4brains/adr/_next/static/chunks/pages/adr/%5B...slug%5D-e208c392dc1424fbafe8.js" as="script"/><style id="jss-server-side">html {
max-width: 100%;
box-sizing: border-box;
-webkit-font-smoothing: antialiased;
Expand Down Expand Up @@ -1973,4 +1973,4 @@
&lt;div&gt;{text}&lt;/div&gt;
{children}
&lt;/div&gt;
);</code></pre></div></div><hr class="MuiDivider-root jss67"/><nav class="jss68"><div></div><div class="jss69"><p class="MuiTypography-root jss70 MuiTypography-body1">Last edited by <!-- -->Thomas Vaillant</p><p class="MuiTypography-root jss70 MuiTypography-body1">on <!-- -->Sep 25, 2020 4:34 PM</p></div><div></div></nav></div><div class="jss74 jss75"></div></div></main><footer class="jss23"><div class="jss2"></div><div class="jss3 jss26"><p class="MuiTypography-root jss24 MuiTypography-body1">Powered by<!-- --> <a class="MuiTypography-root MuiLink-root MuiLink-underlineNone jss25 MuiTypography-colorPrimary" href="https://github.com/thomvaill/log4brains" target="_blank" rel="noopener">Log4brains</a> <span style="font-size:0.8em"></span></p></div><div class="jss4"></div></footer></div></div></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"projectName":"Log4brains","currentAdr":{"slug":"web/20200927-avoid-react-fc-type","package":"web","title":"Avoid React.FC type","status":"accepted","supersededBy":null,"tags":[],"deciders":[],"body":{"enhancedMdx":"\n- Source: \u003chttps://github.com/spotify/backstage/blob/master/docs/architecture-decisions/adr006-avoid-react-fc.md\u003e \u003c!-- TODO: maybe a new feature? --\u003e\n\n## Context\n\nFacebook has removed `React.FC` from their base template for a Typescript\nproject. The reason for this was that it was found to be an unnecessary feature\nwith next to no benefits in combination with a few downsides.\n\nThe main reasons were:\n\n- **children props** were implicitly added\n- **Generic Type** was not supported on children\n\nRead more about the removal in\n[this PR](https://github.com/facebook/create-react-app/pull/8177).\n\n## Decision\n\nTo keep our codebase up to date, we have decided that `React.FC` and `React.SFC`\nshould be avoided in our codebase when adding new code.\n\nHere is an example:\n\n```typescript\n/* Avoid this: */\ntype BadProps = { text: string };\nconst BadComponent: FC\u003cBadProps\u003e = ({ text, children }) =\u003e (\n \u003cdiv\u003e\n \u003cdiv\u003e{text}\u003c/div\u003e\n {children}\n \u003c/div\u003e\n);\n\n/* Do this instead: */\ntype GoodProps = { text: string; children?: React.ReactNode };\nconst GoodComponent = ({ text, children }: GoodProps) =\u003e (\n \u003cdiv\u003e\n \u003cdiv\u003e{text}\u003c/div\u003e\n {children}\n \u003c/div\u003e\n);\n```\n"},"creationDate":"2020-09-25T16:34:23.000Z","lastEditDate":"2020-09-25T16:34:23.000Z","lastEditAuthor":"Thomas Vaillant","publicationDate":"2020-09-27T21:59:59.000Z","file":{"relativePath":"packages/web/docs/adr/20200927-avoid-react-fc-type.md","absolutePath":"/home/runner/work/log4brains/log4brains/packages/web/docs/adr/20200927-avoid-react-fc-type.md"},"repository":{"provider":"github","viewUrl":"https://github.com/thomvaill/log4brains/blob/master/packages/web/docs/adr/20200927-avoid-react-fc-type.md"}},"l4bVersion":""},"__N_SSG":true},"page":"/adr/[...slug]","query":{"slug":["web","20200927-avoid-react-fc-type"]},"buildId":"tHJY9LKvrdlwuYJiojHVN","assetPrefix":"/log4brains/adr","runtimeConfig":{},"isFallback":false,"gsp":true}</script><script nomodule="" src="/log4brains/adr/_next/static/chunks/polyfills-8663811501b5bd5e5ef4.js"></script><script src="/log4brains/adr/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/framework.5ab3178105b977ab7f59.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/commons.c5086e38f95c2aac1a1d.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/main-319220bbc2fa7828d1ea.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/a3e17150ead73d62fba7a33a50672ae3f72841a5.c9a32843ecac6aa7ca03.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/pages/_app-2c237ed8c06376e5e154.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/858546a3.952caa2a5f1090446743.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/580d9fe8.453754220469d52ed050.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/d4b94cf0.b6182e23194ff5c5e218.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/7ede4f97.b879b9f12f9bd2413581.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/45d2d314fc8da5e3d79852782e4a432ad4da6771.631b173fe0f55dca7e34.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/pages/adr/%5B...slug%5D-e208c392dc1424fbafe8.js" async=""></script><script src="/log4brains/adr/_next/static/tHJY9LKvrdlwuYJiojHVN/_buildManifest.js" async=""></script><script src="/log4brains/adr/_next/static/tHJY9LKvrdlwuYJiojHVN/_ssgManifest.js" async=""></script></body></html>
);</code></pre></div></div><hr class="MuiDivider-root jss67"/><nav class="jss68"><div></div><div class="jss69"><p class="MuiTypography-root jss70 MuiTypography-body1">Last edited by <!-- -->Thomas Vaillant</p><p class="MuiTypography-root jss70 MuiTypography-body1">on <!-- -->Sep 25, 2020 4:34 PM</p></div><div></div></nav></div><div class="jss74 jss75"></div></div></main><footer class="jss23"><div class="jss2"></div><div class="jss3 jss26"><p class="MuiTypography-root jss24 MuiTypography-body1">Powered by<!-- --> <a class="MuiTypography-root MuiLink-root MuiLink-underlineNone jss25 MuiTypography-colorPrimary" href="https://github.com/thomvaill/log4brains" target="_blank" rel="noopener">Log4brains</a> <span style="font-size:0.8em"></span></p></div><div class="jss4"></div></footer></div></div></div><script id="__NEXT_DATA__" type="application/json">{"props":{"pageProps":{"projectName":"Log4brains","currentAdr":{"slug":"web/20200927-avoid-react-fc-type","package":"web","title":"Avoid React.FC type","status":"accepted","supersededBy":null,"tags":[],"deciders":[],"body":{"enhancedMdx":"\n- Source: \u003chttps://github.com/spotify/backstage/blob/master/docs/architecture-decisions/adr006-avoid-react-fc.md\u003e \u003c!-- TODO: maybe a new feature? --\u003e\n\n## Context\n\nFacebook has removed `React.FC` from their base template for a Typescript\nproject. The reason for this was that it was found to be an unnecessary feature\nwith next to no benefits in combination with a few downsides.\n\nThe main reasons were:\n\n- **children props** were implicitly added\n- **Generic Type** was not supported on children\n\nRead more about the removal in\n[this PR](https://github.com/facebook/create-react-app/pull/8177).\n\n## Decision\n\nTo keep our codebase up to date, we have decided that `React.FC` and `React.SFC`\nshould be avoided in our codebase when adding new code.\n\nHere is an example:\n\n```typescript\n/* Avoid this: */\ntype BadProps = { text: string };\nconst BadComponent: FC\u003cBadProps\u003e = ({ text, children }) =\u003e (\n \u003cdiv\u003e\n \u003cdiv\u003e{text}\u003c/div\u003e\n {children}\n \u003c/div\u003e\n);\n\n/* Do this instead: */\ntype GoodProps = { text: string; children?: React.ReactNode };\nconst GoodComponent = ({ text, children }: GoodProps) =\u003e (\n \u003cdiv\u003e\n \u003cdiv\u003e{text}\u003c/div\u003e\n {children}\n \u003c/div\u003e\n);\n```\n"},"creationDate":"2020-09-25T16:34:23.000Z","lastEditDate":"2020-09-25T16:34:23.000Z","lastEditAuthor":"Thomas Vaillant","publicationDate":"2020-09-27T21:59:59.000Z","file":{"relativePath":"packages/web/docs/adr/20200927-avoid-react-fc-type.md","absolutePath":"/home/runner/work/log4brains/log4brains/packages/web/docs/adr/20200927-avoid-react-fc-type.md"},"repository":{"provider":"github","viewUrl":"https://github.com/thomvaill/log4brains/blob/master/packages/web/docs/adr/20200927-avoid-react-fc-type.md"}},"l4bVersion":""},"__N_SSG":true},"page":"/adr/[...slug]","query":{"slug":["web","20200927-avoid-react-fc-type"]},"buildId":"4ocCG9Ykl-MkXf5OtA9sD","assetPrefix":"/log4brains/adr","runtimeConfig":{},"isFallback":false,"gsp":true}</script><script nomodule="" src="/log4brains/adr/_next/static/chunks/polyfills-8663811501b5bd5e5ef4.js"></script><script src="/log4brains/adr/_next/static/chunks/webpack-50bee04d1dc61f8adf5b.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/framework.5ab3178105b977ab7f59.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/commons.c5086e38f95c2aac1a1d.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/main-319220bbc2fa7828d1ea.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/a3e17150ead73d62fba7a33a50672ae3f72841a5.c9a32843ecac6aa7ca03.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/pages/_app-2c237ed8c06376e5e154.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/858546a3.952caa2a5f1090446743.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/580d9fe8.453754220469d52ed050.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/d4b94cf0.b6182e23194ff5c5e218.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/7ede4f97.b879b9f12f9bd2413581.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/45d2d314fc8da5e3d79852782e4a432ad4da6771.982bb88915300587cd0e.js" async=""></script><script src="/log4brains/adr/_next/static/chunks/pages/adr/%5B...slug%5D-e208c392dc1424fbafe8.js" async=""></script><script src="/log4brains/adr/_next/static/4ocCG9Ykl-MkXf5OtA9sD/_buildManifest.js" async=""></script><script src="/log4brains/adr/_next/static/4ocCG9Ykl-MkXf5OtA9sD/_ssgManifest.js" async=""></script></body></html>
Loading

0 comments on commit 8890e25

Please sign in to comment.