Make table inherit body's color #1310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This seems on the right path, but there is some inconsistency with font color when a class like For example, Pulse before:
Pulse after:
And for reference, Pulse v4:
|
|
I amended my previous commit.
I updated all the other themes too. |
|
Looks good, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to fix #1308, I quickly realized that hardcoding the values
$table-colordoesn't work great for dark color mode.The best solution I found was to reset the value of
$table-colorlike so:$table-color: initial !default;The effect of this is that the table inherits the color of the body, which works well for all themes in both light and dark modes.