Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platform: intel: drop PLATFORM_DEFAULT_DELAY from platform.h #9655

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

kv2019i
Copy link
Collaborator

@kv2019i kv2019i commented Nov 14, 2024

PLATFORM_DEFAULT_DELAY is not needed in Zephyr builds, so it can be dropped from platform.h for all Intel platforms.

Note: other definitions in platform.h are still used, so starting wth the compeltely unused entries with this PR (see #7248 for context).

PLATFORM_DEFAULT_DELAY is not needed in Zephyr builds, so it
can be dropped from platform.h for all Intel platforms.

Signed-off-by: Kai Vehmanen <[email protected]>
Copy link
Collaborator

@lyakh lyakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it isn't needed because it's also defined in sof/zephyr/include/rtos/wait.h?

@kv2019i
Copy link
Collaborator Author

kv2019i commented Nov 15, 2024

@lyakh wrote:

it isn't needed because it's also defined in sof/zephyr/include/rtos/wait.h?

Ack. But it's only used locally in that file, the define is not used elsewhere. Now submitted #9656 to remove this as well.

@kv2019i kv2019i merged commit 148aad6 into thesofproject:main Nov 18, 2024
44 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants