Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio: DRC: Fix DRC enable control switch handling for HiFi4 #9654

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

singalsu
Copy link
Collaborator

The HiFi4 build is looking for enable only from the configuration blob and the ALSA switch control has no impact. This change unifies the operation with generic and HiFi3 builds.

The HiFi4 build is looking for enable only from the
configuration blob and the ALSA switch control has no impact.
This change unifies the operation with generic and HiFi3
builds.

Signed-off-by: Seppo Ingalsuo <[email protected]>
@singalsu singalsu marked this pull request as ready for review November 14, 2024 12:39
@singalsu singalsu requested a review from a team as a code owner November 14, 2024 12:39
Copy link
Member

@lgirdwood lgirdwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu IIUC this enables support for kcontrol to enable or disable ?

@singalsu
Copy link
Collaborator Author

@singalsu IIUC this enables support for kcontrol to enable or disable ?

After this change the kcontrol can disable DRC. Before this it wasn't possible without applying a passthrough blob. I've missed that hifi4 implementation for listening the control was different.

@kv2019i
Copy link
Collaborator

kv2019i commented Nov 18, 2024

SOFCI TEST

@lgirdwood lgirdwood merged commit 4633f15 into thesofproject:main Nov 18, 2024
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants