Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

look for matching legacy_id if id not found #56

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mlinksva
Copy link

Very crude attempt.

See okfn/licenses#37 (comment)

@Floppy
Copy link
Contributor

Floppy commented Jan 15, 2018

This seems sensible; as you say it could do with testing. You should just be able to add a test in https://github.com/theodi/odlifier/blob/master/spec/license_spec.rb, like the ones at the end, assuming there is an existing license with a legacy_id you can test? If not, we can fake one with VCR, but have a go with a real one first if available.

cc @olivierthereaux

@mlinksva
Copy link
Author

There aren't existing licenses with a legacy id documented, but there should be. I'll follow up after fixing that in okfn/licenses#73

@mlinksva
Copy link
Author

Test added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants