Should the Node package produce a base64 src? #425
Closed
thekevinscott
started this conversation in
Ideas
Replies: 1 comment
-
Tensor output is now the default for Node. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
We encountered a bug whereby models in Node were failing to clip their outputs, resulting in strange behavior for base64 src outputs.
This led me to a question: is there any value in the Node version of the model producing a base64 src output?
In the browser, I believe this makes sense, as presumably a user would want to view their upscaled image after upscaling.
In Node by contrast, I would expect the image to either be saved and served, or served in some binary format, neither of which requires a base64 src. And because of the historical browser focus of this package, the base64 is the default.
I wonder if, for the Node package, base64 support should be discontinued entirely, or whether a tensor output should be the default?
Beta Was this translation helpful? Give feedback.
All reactions