Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Resizable and moveable throughout screen #935

Open
AdityaKhatri opened this issue Sep 8, 2020 · 13 comments
Open

Modal: Resizable and moveable throughout screen #935

AdityaKhatri opened this issue Sep 8, 2020 · 13 comments
Assignees
Labels
design-ui design-ux Improve / affect UX discussion No consensus arrived yet feature Introduce new feature related-client Related to Client

Comments

@AdityaKhatri
Copy link
Member

AdityaKhatri commented Sep 8, 2020

No description provided.

@tnagorra tnagorra added feature Introduce new feature related-client Related to Client labels Sep 15, 2020
@eoglethorpe
Copy link

AC:

*Be able to resize from any corner of a popup - not sure to what extent we should limit this. i.e can a user make it full screen. Mariam?
*Be able to move card when dragging and dropping. not sure if we should limit this to just a portion (i.e. top bar) or the whole popup. Mariam?

@AdityaKhatri @matthew-oglethorpe I feel that this is probably 2 cards? 1 for resize, 1 for move?

@AdityaKhatri
Copy link
Member Author

AdityaKhatri commented Sep 25, 2020

@eoglethorpe , makes sense, but if we are doing it separately, resizing would be a bit weird as we would need to figure out which point to resize it by (center, top-right, top-left, ...). If we do them together, we can let the user do whatever they want. 😄

@eoglethorpe
Copy link

@AdityaKhatri sure, i was just trying to be agile ;)

@Mariam-Asatryan seems i can tag you now

@mariam-yu
Copy link

@Ewan-Oglethorpe @AdityaKhatri not sure if it's me misunderstanding Zube, but what's the context? Which cards are we talking about?

General rule though, limit what the users can do, even if they think they want full flexibility. i.e., if we can resize it for them , let's do that, but anyway, can you guys share some screenshots? Thanks!

@AdityaKhatri
Copy link
Member Author

Hi @Mariam-Asatryan , we are talking about in general all modals through out DEEP, but I do agree on not providing flexibility to users.
We haven't started this task yet.
This was a feature request by Patrice, so maybe we setup a call with him to know more why he wants this feature and if there is a workaround?
@eoglethorpe , what do you think?

@mariam-yu
Copy link

@AdityaKhatri sounds good to discuss with Patrice. If it's in general for modals, probably the best rule would be to make them as standard as possible, one size that goes around whatever content it shows with minimal interactions and buttons. But let me know more.

@AdityaKhatri AdityaKhatri added discussion No consensus arrived yet design-ui design-ux Improve / affect UX labels Oct 1, 2020
@mariam-yu
Copy link

Final discussion was: make them movable but not resizable. Hope works for everyone, and we can explore further in more detail.

@AdityaKhatri
Copy link
Member Author

AdityaKhatri commented Oct 7, 2020

Should we provide the moveable feature to all modals in DEEP or should it be selective?
Also, should we do it for elements such as entry comments?
@eoglethorpe @Mariam-Asatryan

@mariam-yu
Copy link

@AdityaKhatri we still will tackle the comments. I would say if it's a separate module in dev don't touch it yet. For everything else, consistency is good. Do you guys have a list by chance of all the modals/popups?

@AdityaKhatri
Copy link
Member Author

@Mariam-Asatryan , there are about ~71 unique Modal, and ~70 confirmation Modals from a quick analysis.

@mariam-yu
Copy link

Woa! @AdityaKhatri What's a unique modal?

@eoglethorpe
Copy link

mo' modals mo' problems

@AdityaKhatri
Copy link
Member Author

@Mariam-Asatryan , confirmation modal are pretty similar to each other.
By unique modal, I mean modals that are not similar to each other and have different purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-ui design-ux Improve / affect UX discussion No consensus arrived yet feature Introduce new feature related-client Related to Client
Projects
None yet
Development

No branches or pull requests

5 participants