-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modal: Resizable and moveable throughout screen #935
Comments
AC: *Be able to resize from any corner of a popup - not sure to what extent we should limit this. i.e can a user make it full screen. Mariam? @AdityaKhatri @matthew-oglethorpe I feel that this is probably 2 cards? 1 for resize, 1 for move? |
@eoglethorpe , makes sense, but if we are doing it separately, resizing would be a bit weird as we would need to figure out which point to resize it by (center, top-right, top-left, ...). If we do them together, we can let the user do whatever they want. 😄 |
@AdityaKhatri sure, i was just trying to be agile ;) @Mariam-Asatryan seems i can tag you now |
@Ewan-Oglethorpe @AdityaKhatri not sure if it's me misunderstanding Zube, but what's the context? Which cards are we talking about? General rule though, limit what the users can do, even if they think they want full flexibility. i.e., if we can resize it for them , let's do that, but anyway, can you guys share some screenshots? Thanks! |
Hi @Mariam-Asatryan , we are talking about in general all modals through out DEEP, but I do agree on not providing flexibility to users. |
@AdityaKhatri sounds good to discuss with Patrice. If it's in general for modals, probably the best rule would be to make them as standard as possible, one size that goes around whatever content it shows with minimal interactions and buttons. But let me know more. |
Final discussion was: make them movable but not resizable. Hope works for everyone, and we can explore further in more detail. |
Should we provide the moveable feature to all modals in DEEP or should it be selective? |
@AdityaKhatri we still will tackle the comments. I would say if it's a separate module in dev don't touch it yet. For everything else, consistency is good. Do you guys have a list by chance of all the modals/popups? |
@Mariam-Asatryan , there are about ~71 unique Modal, and ~70 confirmation Modals from a quick analysis. |
Woa! @AdityaKhatri What's a unique modal? |
mo' modals mo' problems |
@Mariam-Asatryan , confirmation modal are pretty similar to each other. |
No description provided.
The text was updated successfully, but these errors were encountered: