New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InfinitePlane onBackgroundMoved returns NaN due to call site #25

Open

ShadowLarkens opened this issue Oct 5, 2024 · 0 comments

ShadowLarkens commented Oct 5, 2024

tgui-core/lib/components/InfinitePlane.jsx

Lines 113 to 115 in b147479

    
           if (onBackgroundMoved) { 
        
             onBackgroundMoved(newX + initialLeft, newY + initialTop); 
        
           }

This needs to be inside the setState, or it accesses newX and newY as undefined, and therefore always calls the callback with NaN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment