Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for Sqlite ProgramingError Exception #1106

Merged
merged 5 commits into from
Oct 28, 2024
Merged

Check for Sqlite ProgramingError Exception #1106

merged 5 commits into from
Oct 28, 2024

Conversation

romer8
Copy link
Contributor

@romer8 romer8 commented Oct 23, 2024 •
edited
Loading

Description

This merge request addresses the sqlite programming error that is triggered when harvesting apps on the method _harvest_app_instances on the file tethys_apps/harvester.py.

Changes Made to Code:

  • _harvest_app_instances added exception for sqlite3 ProgramingError
  • Added test

Quality Checks

  • New code is 100% tested
  • Code has been formated
  • Code has been linted
  • Docstrings for new methods have been added

@coveralls
Copy link

coveralls commented Oct 23, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling cbdcf73 on romer8:sqlite-exception
into d4a8761 on tethysplatform:main.

@swainn swainn merged commit da1d12a into tethysplatform:main Oct 28, 2024
42 checks passed
@sdc50 sdc50 added the bugfix label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swainn swainn swainn approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romer8 @coveralls @swainn @sdc50