Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] micro-tethys-platform requires django4.2 #1108

Closed
sdc50 opened this issue Oct 29, 2024 · 2 comments
Closed

[BUG] micro-tethys-platform requires django4.2 #1108

sdc50 opened this issue Oct 29, 2024 · 2 comments
Labels

Comments

@sdc50
Copy link
Member

sdc50 commented Oct 29, 2024

When installing the latest dev build of micro-tethys-platform it will only install with django=4.2 (i.e. not django=4.2.*).

Looking for: ['micro-tethys-platform=4.2.0.post3.dev62', 'django=4.2.16']

tethysplatform/label/dev/osx-arm64                          Using cache
tethysplatform/label/dev/noarch                             Using cache
conda-forge/osx-arm64                                       Using cache
conda-forge/noarch                                          Using cache
Encountered problems while solving:
  - package micro-tethys-platform-4.2.0.post3.dev62+gda1d12a9.d20241028-dev62_gda1d12a9 requires django 4.2, but none of the providers can be installed

When I unpin micro-tethys-platform it resolves to micro-tethys-platform-4.2.0.post3.dev26, so something happened since then that prevents the patch versions of django to be compatible.

@sdc50 sdc50 added the bug label Oct 29, 2024
@sdc50
Copy link
Member Author

sdc50 commented Oct 29, 2024

I think the == in the install_tethys.sh is causing the issue.

        echo "Updating environment.yml Django version ${DJANGO_VERSION}..."
        sudo sed -i.bak "s/django>=.*/django==${DJANGO_VERSION}/" "${TETHYS_SRC}/environment.yml"
        sudo sed -i.bak "s/django>=.*/django==${DJANGO_VERSION}/" "${TETHYS_SRC}/micro_environment.yml"

If we replace it with just = then it will allow other patch versions of django=4.2. However, I think we want the conda packages to be installed with several versions of django/version. Since the conda recipe is derived from the environment.yml file I think we need to not modify the file, but just update the environment after creating it.

@sdc50
Copy link
Member Author

sdc50 commented Oct 31, 2024

fixed by #1109

@sdc50 sdc50 closed this as completed Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant