-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support for go.work #2849
Open
mdelapenya
wants to merge
35
commits into
testcontainers:main
Choose a base branch
from
mdelapenya:go-workfile
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
0af0767
feat: support for generating the go.work file
mdelapenya 26ce7cc
fix: update tests to assert the new module is added to all files
mdelapenya ea14e6b
fix: normalize go version across modules
mdelapenya 75147a9
chore: lint
mdelapenya a083e9f
chore: move test
mdelapenya cb56778
chore: remove unused function
mdelapenya 04fde29
chore: format errors
mdelapenya 7d64155
chore: merge generate module tests
mdelapenya e4b8d22
chore: return zero value for root context if error
mdelapenya 6da6a1e
fix: use t.Helper
mdelapenya ea005eb
chore: use modfile package to handle workfiles
mdelapenya 14cab8e
chore: remove duplicated tests
mdelapenya 8c17d3e
chore: move tests
mdelapenya 711e50c
chore: assert against types, not strings
mdelapenya 36a08a9
chore: remove unused template
mdelapenya 255b953
docs: proper comments
mdelapenya 11d0d76
chore: proper error message
mdelapenya 0f9f98a
chore: include go.work file in git
mdelapenya d2421ba
chore: remove unused file
mdelapenya b08b839
chore: go work sync
mdelapenya 87210d6
fix: resolve AWS deprecations for localstack
mdelapenya e0859c7
chore: run mod tidy
mdelapenya cdf541e
fix: mod tidy
mdelapenya 693e1df
fix: include modulegen tidy in tidy-all
mdelapenya 0463cc6
Merge branch 'main' into go-workfile
mdelapenya ac85826
Merge branch 'main' into go-workfile
mdelapenya 6727948
Revert "chore: return zero value for root context if error"
mdelapenya c553a3d
chore: simplify test dirs creation
mdelapenya 1628cec
chore: simpler test names
mdelapenya 4d9762d
chore: remove useless comment
mdelapenya 2c75d9a
chore: wrap error
mdelapenya cd0788c
docs: document new type
mdelapenya 8212bd1
fix: wrong copy&paste in error message
mdelapenya 047e7bb
docs: document exposed funtions
mdelapenya cbfdea7
Merge branch 'main' into go-workfile
mdelapenya File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,5 @@ TEST-*.xml | |
|
||
tcvenv | ||
|
||
**/go.work | ||
|
||
# VS Code settings | ||
.vscode |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: do we want it committed or part of a setup process? Typically its not standard to add this, but I wonder if this is a good example for it?