Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] terramate install-completions on fish tries to complete with descriptions and whitespace #1739

Open
ehakan opened this issue Jun 1, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@ehakan
Copy link

ehakan commented Jun 1, 2024

Describe the bug
The tab completions on fish shell don't just select the command, they include command descriptions as well, including whitespaces.

It does work properly if I type out a section an command first. Type terramate cre and then press TAB, it completes create properly.

But typing just terramate <space> and then pressing TAB tries to pick descriptions.

After pressing tab:
image

After selection an option with the arrow keys:
image

image

To Reproduce:

  1. Run terramate install-completions on fish shell
  2. Type terramate<space><tab>
    • The options are already a bit garbled at this point
  3. Use the arrow keys to select an option
    • Now the description appears in the prompt

Expected behavior
Fish completed descriptions normally appear like this:
image

Log Output
Add logs from Terramate to help debug your problem.

Environment (please complete the following information):

  • OS: macOS
  • OS Version: Sonoma 14.4.1 (23E224)
  • Git Version: git version 2.45.2
  • Terramate Version: 0.8.4
  • Terminal Emulator: wezterm 20240203-110809-5046fc22
  • Shell: fish, version 3.7.1
  • Prompt: starship 1.19.0

Additional Info
Took a look at cli.go. I'm more familiar with spf13/cobra than kong so can't comment on it, but I also couldn't find an issue related to this on kong or kongplete.

@ehakan ehakan added the bug Something isn't working label Jun 1, 2024
@i4ki
Copy link
Contributor

i4ki commented Jun 7, 2024

Hi @ehakan

Yes, I'm not a fish user but I installed here and reproduced the same behavior.
We depend on a library for these completions and we will have to report it upstream, maybe fork and fix ourselves.

Thanks for reporting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants