Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests, CI badge, make tests run faster #451

Open
2 tasks done
oraclown opened this issue Nov 22, 2022 · 3 comments
Open
2 tasks done

Fix tests, CI badge, make tests run faster #451

oraclown opened this issue Nov 22, 2022 · 3 comments

Comments

@oraclown
Copy link
Collaborator

oraclown commented Nov 22, 2022

These tests are failing (for akrem):

  • tests/reporters/test_custom_360_reporter.py::test_submit_once
  • tests/reporters/test_polygon_reporter.py
@oraclown oraclown mentioned this issue Nov 22, 2022
3 tasks
@oraclown
Copy link
Collaborator Author

Reporter tests failing on my local:

==================================================================== short test summary info ====================================================================
FAILED tests/reporters/test_360reporter.py::test_report - assert 0 == 1000000000000000000
FAILED tests/reporters/test_360reporter.py::test_adding_stake - assert False
FAILED tests/reporters/test_360reporter.py::test_no_native_token - assert 'insufficient native token funds' in "info     telliot_feeds.reporters.tellor_360:te...
FAILED tests/reporters/test_custom_360_reporter.py::test_submit_once - AssertionError: assert False
FAILED tests/reporters/test_polygon_reporter.py::test_fetch_gas_price_error - AssertionError: assert 'Invalid gas price speed for matic gasstation: blah' in '...
FAILED tests/reporters/test_rng_reporter.py::test_report - assert "Unable to stake deposit: Send transaction failed: ValueError({'message': 'VM Exception whil...
====================================================== 6 failed, 32 passed, 1 warning in 115.35s (0:01:55) ======================================================

looks like tests/reporters/test_360reporter.py::test_no_native_token fails when run with the group, but not alone

@oraclown
Copy link
Collaborator Author

oraclown commented Nov 23, 2022

Another thing:

  • make it not ask for a Rinkeby account when you run tests locally
  • ensure all tests pass locally when running tox

@oraclown oraclown changed the title Fix tests Fix tests, CI badge, make tests run faster Feb 2, 2023
@oraclown
Copy link
Collaborator Author

oraclown commented Feb 2, 2023

To do:

  • CI runs pass even though some tests might fail
  • Remove CodeCov or fix it. this and this
  • Entire test suite takes like minutes to run. Make faster so dev workflow isn't painful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants