From 03cdd4ce049121edae9acda38235389464bfb785 Mon Sep 17 00:00:00 2001 From: felix-ico <97440128+felix-ico@users.noreply.github.com> Date: Mon, 11 Dec 2023 11:53:45 +0100 Subject: [PATCH 1/2] fix(telekom-header): prevent flicker that could make the footer unreachable (#2230) * fix: add fixed height on the base to prevent flicker * style: format --------- Co-authored-by: felixw --- .../telekom/telekom-header/telekom-header.css | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/packages/components/src/components/telekom/telekom-header/telekom-header.css b/packages/components/src/components/telekom/telekom-header/telekom-header.css index 1c7308059f..78fbd01b67 100644 --- a/packages/components/src/components/telekom/telekom-header/telekom-header.css +++ b/packages/components/src/components/telekom/telekom-header/telekom-header.css @@ -26,6 +26,7 @@ --font-weight-app-name: var(--telekom-typography-font-weight-extra-bold); --_height: 60px; + --_base-height: 60px; --_height-logo-svg: 36px; --_height-bottom-bar: 60px; --_height-top-bar: 0; @@ -68,6 +69,8 @@ :host, :host([scrolled-back]) { --_height: 84px; + --_base-height: 84px; + --_height-logo-svg: 44px; --_height-top-bar: 30px; --_height-bottom-bar: 54px; @@ -96,6 +99,7 @@ --telekom-spacing-composition-space-07 ); } + :host([type='slim'][scrolled]) { --_spacing-right-bottom-app-name: var( --telekom-spacing-composition-space-07 @@ -104,6 +108,7 @@ :host([type='slim']), :host([scrolled]) { --_height: 72px; + --_height-logo-svg: 40px; --_height-top-bar: 0; --_height-bottom-bar: 72px; @@ -130,6 +135,8 @@ :host, :host([scrolled-back]) { --_height: 96px; + --_base-height: 96px; + --_height-logo-svg: 48px; --_height-top-bar: 30px; --_height-bottom-bar: 66px; @@ -139,6 +146,8 @@ :host([type='slim']) { --_height: 84px; + --_base-height: 84px; + --_height-logo-svg: 44px; --_height-top-bar: 0; --_height-bottom-bar: 84px; @@ -163,6 +172,8 @@ :host, :host([scrolled-back]) { --_height: 120px; + --_base-height: 120px; + --_height-logo-svg: 60px; --_height-top-bar: 30px; --_height-bottom-bar: 90px; @@ -181,6 +192,8 @@ :host([type='slim']) { --_height: 96px; + --_base-height: 96px; + --_height-logo-svg: 48px; --_height-top-bar: 0; --_height-bottom-bar: 96px; @@ -202,6 +215,7 @@ :host([type='slim'][scrolled]) { --_height: 72px; + --_height-logo-svg: 40px; --_height-top-bar: 0; --_height-bottom-bar: 72px; @@ -269,7 +283,8 @@ slot[name='functions'] { } [part~='base'] { - height: var(--_height); + /* height: var(--_height); */ + height: var(--_base-height); width: 100%; transition: var(--transition-common-scrolled); } From 9510a804aeb360682011c05b2af87b7784856c30 Mon Sep 17 00:00:00 2001 From: Arturo Date: Mon, 11 Dec 2023 15:24:01 +0100 Subject: [PATCH 2/2] chore(release): publish --- CHANGELOG.md | 11 +++++++++++ lerna.json | 2 +- packages/components-angular/CHANGELOG.md | 8 ++++++++ packages/components-angular/package.json | 2 +- packages/components-react/CHANGELOG.md | 8 ++++++++ packages/components-react/package.json | 2 +- packages/components-vue/CHANGELOG.md | 8 ++++++++ packages/components-vue/package.json | 2 +- packages/components/CHANGELOG.md | 11 +++++++++++ packages/components/package.json | 4 ++-- packages/design-tokens/CHANGELOG.md | 8 ++++++++ packages/design-tokens/package.json | 2 +- packages/storybook-vue/CHANGELOG.md | 8 ++++++++ packages/storybook-vue/package.json | 6 +++--- packages/visual-tests/CHANGELOG.md | 8 ++++++++ packages/visual-tests/package.json | 2 +- 16 files changed, 81 insertions(+), 11 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 269d3107ac..46b3a07af8 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + + +### Bug Fixes + +* **telekom-header:** prevent flicker that could make the footer unreachable ([#2230](https://github.com/telekom/scale/issues/2230)) ([03cdd4c](https://github.com/telekom/scale/commit/03cdd4ce049121edae9acda38235389464bfb785)) + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) diff --git a/lerna.json b/lerna.json index 0470561d82..b14af47bf4 100644 --- a/lerna.json +++ b/lerna.json @@ -7,7 +7,7 @@ "--pure-lockfile" ], "useWorkspaces": true, - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "command": { "version": { "allowBranch": "main" diff --git a/packages/components-angular/CHANGELOG.md b/packages/components-angular/CHANGELOG.md index 7c130b3582..e7dc69cf5b 100644 --- a/packages/components-angular/CHANGELOG.md +++ b/packages/components-angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + +**Note:** Version bump only for package @telekom/scale-components-angular + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) **Note:** Version bump only for package @telekom/scale-components-angular diff --git a/packages/components-angular/package.json b/packages/components-angular/package.json index bacd09a7dd..424a695dde 100644 --- a/packages/components-angular/package.json +++ b/packages/components-angular/package.json @@ -1,6 +1,6 @@ { "name": "@telekom/scale-components-angular", - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "description": "Angular specific wrapper for @telekom/scale-components", "license": "MPL-2.0", "homepage": "https://github.com/telekom/scale", diff --git a/packages/components-react/CHANGELOG.md b/packages/components-react/CHANGELOG.md index f9ce0b3eae..a26f114a68 100644 --- a/packages/components-react/CHANGELOG.md +++ b/packages/components-react/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + +**Note:** Version bump only for package @telekom/scale-components-react + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) **Note:** Version bump only for package @telekom/scale-components-react diff --git a/packages/components-react/package.json b/packages/components-react/package.json index 00b879d872..e56fe15cee 100755 --- a/packages/components-react/package.json +++ b/packages/components-react/package.json @@ -1,7 +1,7 @@ { "name": "@telekom/scale-components-react", "sideEffects": false, - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "description": "React proxy for @telekom/scale-components", "license": "MPL-2.0", "homepage": "https://github.com/telekom/scale", diff --git a/packages/components-vue/CHANGELOG.md b/packages/components-vue/CHANGELOG.md index a2a7f0e989..6382b35922 100644 --- a/packages/components-vue/CHANGELOG.md +++ b/packages/components-vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + +**Note:** Version bump only for package @telekom/scale-components-vue + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) **Note:** Version bump only for package @telekom/scale-components-vue diff --git a/packages/components-vue/package.json b/packages/components-vue/package.json index 54fd3c7af6..6d6f9dd5b5 100644 --- a/packages/components-vue/package.json +++ b/packages/components-vue/package.json @@ -1,7 +1,7 @@ { "name": "@telekom/scale-components-vue", "sideEffects": false, - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "description": "Vue specific wrapper for @telekom/scale-components", "license": "MPL-2.0", "homepage": "https://github.com/telekom/scale", diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md index d0ae019bbe..9da56d34f8 100644 --- a/packages/components/CHANGELOG.md +++ b/packages/components/CHANGELOG.md @@ -3,6 +3,17 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + + +### Bug Fixes + +* **telekom-header:** prevent flicker that could make the footer unreachable ([#2230](https://github.com/telekom/scale/issues/2230)) ([03cdd4c](https://github.com/telekom/scale/commit/03cdd4ce049121edae9acda38235389464bfb785)) + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) diff --git a/packages/components/package.json b/packages/components/package.json index 5b9b7871f1..1f1b7a14b6 100644 --- a/packages/components/package.json +++ b/packages/components/package.json @@ -1,6 +1,6 @@ { "name": "@telekom/scale-components", - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "description": "Scale is the digital design system for Telekom products and experiences.", "homepage": "https://github.com/telekom/scale", "repository": { @@ -73,7 +73,7 @@ "@floating-ui/dom": "^1.2.8", "@stencil/core": "^2.17.0", "@telekom/design-tokens": "1.0.0-beta.10", - "@telekom/scale-design-tokens": "^3.0.0-beta.144", + "@telekom/scale-design-tokens": "^3.0.0-beta.145", "classnames": "^2.2.6", "composed-offset-position": "^0.0.4", "stencil-inline-svg": "^1.0.1" diff --git a/packages/design-tokens/CHANGELOG.md b/packages/design-tokens/CHANGELOG.md index 3b1b221a39..3245a52959 100644 --- a/packages/design-tokens/CHANGELOG.md +++ b/packages/design-tokens/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + +**Note:** Version bump only for package @telekom/scale-design-tokens + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) **Note:** Version bump only for package @telekom/scale-design-tokens diff --git a/packages/design-tokens/package.json b/packages/design-tokens/package.json index 876f33ee21..5f16b73808 100644 --- a/packages/design-tokens/package.json +++ b/packages/design-tokens/package.json @@ -1,6 +1,6 @@ { "name": "@telekom/scale-design-tokens", - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "type": "module", "description": "Design Tokens for the Scale Design System", "homepage": "https://github.com/telekom/scale", diff --git a/packages/storybook-vue/CHANGELOG.md b/packages/storybook-vue/CHANGELOG.md index 4f793b4b8c..24b4a12365 100644 --- a/packages/storybook-vue/CHANGELOG.md +++ b/packages/storybook-vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + +**Note:** Version bump only for package @telekom/scale-storybook-vue + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) diff --git a/packages/storybook-vue/package.json b/packages/storybook-vue/package.json index 15f022c12d..926f2bd9c9 100644 --- a/packages/storybook-vue/package.json +++ b/packages/storybook-vue/package.json @@ -2,7 +2,7 @@ "homepage": "https://telekom.github.io/scale", "name": "@telekom/scale-storybook-vue", "private": true, - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "main": "index.js", "license": "MPL-2.0", "devDependencies": { @@ -32,8 +32,8 @@ "dependencies": { "@storybook/addon-viewport": "^6.4.22", "@telekom/design-tokens": "^1.0.0-beta.2", - "@telekom/scale-components": "^3.0.0-beta.144", - "@telekom/scale-components-vue": "^3.0.0-beta.144" + "@telekom/scale-components": "^3.0.0-beta.145", + "@telekom/scale-components-vue": "^3.0.0-beta.145" }, "scripts": { "prestart": "rm -rf node_modules/.cache/ && yes | cp -a ../components/dist/scale-components/fonts/* public/fonts/ && yes | cp -a ../components/dist/scale-components/scale-components.css public/", diff --git a/packages/visual-tests/CHANGELOG.md b/packages/visual-tests/CHANGELOG.md index d9562ddcd4..59dcf2d4b0 100644 --- a/packages/visual-tests/CHANGELOG.md +++ b/packages/visual-tests/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +# [3.0.0-beta.145](https://github.com/telekom/scale/compare/v3.0.0-beta.144...v3.0.0-beta.145) (2023-12-11) + +**Note:** Version bump only for package @telekom/scale-visual-tests + + + + + # [3.0.0-beta.144](https://github.com/telekom/scale/compare/v3.0.0-beta.143...v3.0.0-beta.144) (2023-11-30) **Note:** Version bump only for package @telekom/scale-visual-tests diff --git a/packages/visual-tests/package.json b/packages/visual-tests/package.json index fcaeb8ccd7..62d7c88400 100644 --- a/packages/visual-tests/package.json +++ b/packages/visual-tests/package.json @@ -1,7 +1,7 @@ { "name": "@telekom/scale-visual-tests", "private": true, - "version": "3.0.0-beta.144", + "version": "3.0.0-beta.145", "main": "index.js", "license": "MPL-2.0", "scripts": {