From b2b40b90918543f413db2d4000a7d01f9b0efd71 Mon Sep 17 00:00:00 2001 From: Emil Thies Date: Tue, 21 May 2024 14:11:42 +0200 Subject: [PATCH] Use PhoneLib 8.13.37, update test for fix of our issue 338710341 and prepare release --- REPORTED_ISSUES.md | 4 ++- pom.xml | 6 ++-- .../PhoneNumberOfflineGeocoderTest.groovy | 28 ++++++++++++++----- 3 files changed, 27 insertions(+), 11 deletions(-) diff --git a/REPORTED_ISSUES.md b/REPORTED_ISSUES.md index a636d6a..e016332 100644 --- a/REPORTED_ISSUES.md +++ b/REPORTED_ISSUES.md @@ -46,4 +46,6 @@ When we have further insights, we will report them as issues, re-engage with Goo BnetzA [described special case for NDC 212 and 621](https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1) the first one is correctly recognized by geocoder and the two cities are correctly labeled. But the second case is not recognized and only the city Mannheim is used for labeling and not Ludwigshafen. -We have provided Ludwighafen in our labeling data. \ No newline at end of file +We have provided Ludwighafen in our labeling data. + +Google [fixed](https://github.com/google/libphonenumber/pull/3473/files#diff-db8e5b3fb2cb4a7ed9856289ea12d54947bfaa10549e6c1058fec7f3a1359dbbR3260) ít with [8.13.37](https://github.com/google/libphonenumber/pull/3473) on 15.05.2024. \ No newline at end of file diff --git a/pom.xml b/pom.xml index 403c461..e76fc80 100644 --- a/pom.xml +++ b/pom.xml @@ -23,7 +23,7 @@ normalizer Phonenumber Normalizer Library to work with phonenumbers, especially to fix googles PhoneLib ignoring German Landline specifics. - 1.2.2-SNAPSHOT + 1.2.2 jar https://github.com/telekom/phonenumber-normalizer @@ -86,7 +86,7 @@ com.googlecode.libphonenumber libphonenumber - 8.13.36 + 8.13.37 @@ -150,7 +150,7 @@ com.googlecode.libphonenumber geocoder - 2.230 + 2.231 test diff --git a/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy b/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy index 92da86e..7cd3626 100644 --- a/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy +++ b/src/test/groovy/de/telekom/phonenumbernormalizer/extern/libphonenumber/PhoneNumberOfflineGeocoderTest.groovy @@ -3307,13 +3307,27 @@ class PhoneNumberOfflineGeocoderTest extends Specification { "6206" | "Lampertheim" | false "6207" | "Wald Michelbach" | false "6209" | "Mörlenbach" | false - "621" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen - // note of BnetzA, that starting number is sperating both cities: see https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1 - "6215" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 - "6216" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 - "62195" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 - "62196" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 - "62199" | "Ludwigshafen" | true // see https://issuetracker.google.com/issues/338710341 + // 621 extended 0..4, 7&8 because number with starting 5 is added + "6210" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "6211" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "6212" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "6213" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "6214" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + // note of BnetzA, that starting number is separating both cities: see https://www.bundesnetzagentur.de/SharedDocs/Downloads/DE/Sachgebiete/Telekommunikation/Unternehmen_Institutionen/Nummerierung/Rufnummern/ONVerzeichnisse/ONBVerzeichnis/Sonderregelungen0212_0621.pdf?__blob=publicationFile&v=1 + "6215" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341 + "6216" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341 + "6217" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "6218" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62190" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62191" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62192" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62193" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62194" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62195" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341 + "62196" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341 + "62197" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62198" | "Mannheim" | false // main BnetzA number plan - but shared with Ludwigshafen + "62199" | "Ludwigshafen" | false // see https://issuetracker.google.com/issues/338710341 "6220" | "Wilhelmsfeld" | false "6221" | "Heidelberg" | false "6222" | "Wiesloch" | false