Be/#284 토큰 재발급 API 리팩토링 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimhalin
reviewed
Nov 7, 2023
| String requestToken = filter.resolveToken(request); | ||
| tokenProvider.validateToken(requestToken); | ||
|
|
||
| RefreshToken savedRefreshToken = refreshTokenRepository.findByEmail(member.getEmail()); | ||
| String email = tokenProvider.getEmailInAuthentication(requestToken); |
There was a problem hiding this comment.
line 71에 보면 String email = tokenProvider.getAuthentication(request.getAccessToken()).getName(); 처럼 토큰에서 email을 가져오는 코드가 있는데 여기도 함수로 바꿔주면 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛠️ 변경사항
☝️ 유의사항
👀 참고자료
❗체크리스트