Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/custom confirmation #94

Merged
merged 4 commits into from
Jan 31, 2024
Merged

Conversation

otytlandsvik
Copy link
Contributor

✨ Add support for custom emails to event participants

Modified /event/{eid}/confirm endpoint

  • Now supports custom email body from payload
  • Added /event/{eid}/confirm-message endpoint to fetch default confirm mail with event data

Added /event/{eid}/mail endpoint

Allows admins to send custom emails to event participants. Can choose between

  • All participants
  • All confirmed participants

🎨 Formatting

Ran autopep8 on various files

⚠️ Should be merged simultaneously with corresponding frontend PR

Copy link
Member

@FredrikMorstad FredrikMorstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and a very nice feature to have 🙌 Something to consider is to run the email sending in the background as it takes some time to send all the mails

app/api/events.py Outdated Show resolved Hide resolved
@otytlandsvik otytlandsvik merged commit 4f2b5fb into master Jan 31, 2024
1 check passed
@otytlandsvik otytlandsvik deleted the feature/custom-confirmation branch January 31, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants