Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing some inaccuracies #78

Closed
wants to merge 2 commits into from
Closed

Conversation

cdelzotti
Copy link
Contributor

Hello, I found some inaccuracies within npf :

  • Some code in the zltexp design wasn't working as expected when the maximum rate had been reached and some configurations remained.
  • Weirdly enough, some components were set as inactive in the packet-generating module, keeping NPF from sending packets.

…rst dropping rate (i.e. If the current variables already do the max throughput) just skip monotonic processing
@tbarbette
Copy link
Owner

tbarbette commented Oct 31, 2024

It would be better to do a PR per topic

For the packet generation, it is enabled after some delay by

write fdIN{{ t }}.active true,
can you run with --show-files to see the value?

Seems ok for the ZLT. But I can't merge then :) It would be great to add a failing testcase (with an example script in integration.sh or a python unittest in integration/unittest.py) and show how it is solved here. But that's optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants