Fix logging of failure on Customer removal #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can this get merged? |
|
Apparently not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Closes #353
Description
Pre v2, TJ interaction w/ Customer object used Observer classes which extended an abstract class where this logger was originally included. With changes to core code and deprecation of previously observed events, these interactions were migrated to use Plugins instead.
Although the happy-path was not affected by this bug, if TaxJar fails to delete a customer for some reason, the absence of a Logger in the CustomerRepository Plugin would not be able to log the error and would also cause the Magento customer deletion process to fail.
Performance
N/A - bug fix
Testing
Added unit test coverage for changes
Versions