<ref> should ignore whitespace preformatted lines
#339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes second part of #336
xxyzz
approved these changes
Nov 18, 2024
|
Thanks for the fix! And I also add the "p" tag to the "if" check line. |
|
Thanks for finishing this for me while I was away, lol, I just figured out what was happening; in my branch, I had a commit that removed the for loop and replaced it with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes second part of #336
When we would normally be pushing a layer of NodeKind.PREFORMATTED, check if the stack has any HTML-elements with the
<ref>tag and if that is the case don't push PREFORMATTED.If other HTML-like tags need this in the future (onlyinclude? includeonly??) then this is the place where to add those checks.
Looking through the stack could be better. Filter? Any? Oh yeah, duh.