Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thank you! #21

Open
ORESoftware opened this issue Nov 2, 2023 · 0 comments
Open

thank you! #21

ORESoftware opened this issue Nov 2, 2023 · 0 comments

Comments

@ORESoftware
Copy link

ORESoftware commented Nov 2, 2023

I tested this module - it appears to be significantly more performant than using the equivalent functionality with the old domain module. It also seems to capture all the random async errors I threw at it (take that with a grain of salt, but so far so good).

So congrats to node core for implementing async-hooks, and thank you for creating this user-land library which re-creates the domain functionality, which is very important for my use cases, and I hope serves a strong purpose to other users going forward.

Not only is it more performant, but it should fix problems in both core and userland, so that users don't have to do this in userland:

if(process.domain){
   fn = process.domain.bind(fn);
}

(I hope!)

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant