Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QUESTION] Is CQL(rho) implemented? #303

Open
raunakkbanerjee opened this issue Jul 28, 2023 · 1 comment
Open

[QUESTION] Is CQL(rho) implemented? #303

raunakkbanerjee opened this issue Jul 28, 2023 · 1 comment

Comments

@raunakkbanerjee
Copy link

raunakkbanerjee commented Jul 28, 2023

Hello @takuseno,
For adroit tasks, the original paper mentions using CQL(rho). This can be used by setting min_q_version=2 in the code provided by the authors. I am curious if this is implemented in d3rlpy. If so, how can I use this version of CQL?

Many thanks for your time.

@takuseno
Copy link
Owner

@raunakkbanerjee Hi, thanks for the issue. Currently, it's not supported yet because it's usually performing worse and I don't see people using it in the recent publication. But, since it's actually easy to support in the upcoming release, I'll consider it in the next update. Or, I'm always welcoming contributions from you 😄

Just to be sure, in the rho version, the regularizer will be this simple term:
https://github.com/aviralkumar2907/CQL/blob/d67dbe9cf5d2b96e3b462b6146f249b3d6569796/d4rl/rlkit/torch/sac/cql.py#L245

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants