Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v.4.2.3 docker build always fails because it cannot find package Tools.TableauServerRestApi #168

Open
til-jmac opened this issue Feb 15, 2023 · 7 comments

Comments

@til-jmac
Copy link

til-jmac commented Feb 15, 2023

@zhuoyanggao Since v4.2.3 the docker build process is broken, with the error as described in #165

The following commit appears to be the cause:
d0c0ca9#diff-6fe1e64645078ab18848d369ae5ee3d3f9ff22943ae39c5a84d61f087635daeb

Reverting this change so that the package can be found in the relevant path in the source code resolves the issue. Any reason this can't be updated in the latest version so that we can use it in docker?

Credit to @petersilv for spotting this

@til-jmac til-jmac changed the title v.4.3.2 docker build always fails because it cannot find package Tools.TableauServerRestApi v.4.2.3 docker build always fails because it cannot find package Tools.TableauServerRestApi Feb 15, 2023
@jay2610
Copy link

jay2610 commented Feb 15, 2023

Having the same issue

@zhuoyanggao
Copy link
Contributor

zhuoyanggao commented Feb 15, 2023

Hi @jay2610 and @til-jmac ,

Wonder if below work-around would help:

Revert all changes in Logshark/Logshark.csproj locally, and retry build.
d0c0ca9#diff-6fe1e64645078ab18848d369ae5ee3d3f9ff22943ae39c5a84d61f087635daeb

We might be releasing a patch for this in the coming weeks.

@zhuoyanggao
Copy link
Contributor

@til-jmac This is due to a missing manual step in the release process. Those changes should not have been there in the 4.2.3 release.

@til-jmac
Copy link
Author

@til-jmac This is due to a missing manual step in the release process. Those changes should not have been there in the 4.2.3 release.

Thanks for the reply. Reverting the changes locally does work, just wanted to raise it so a fix can be incorporated.

@tb582
Copy link

tb582 commented Mar 23, 2023

any update here ? or more detail on how to update locally?

@rickymedrano
Copy link

rickymedrano commented Apr 24, 2023

any update here ? or more detail on how to update locally?

Open Logshark/LogShark.csproj and add this after the last </ItemGroup> (for me this was on line 60)

<ItemGroup>
<Reference Include="Tools.TableauServerRestApi">
<HintPath>..\thirdparty\Tools.TableauServerRestApi.dll</HintPath>
</Reference>
</ItemGroup> 

@tb582
Copy link

tb582 commented Dec 5, 2023

how is this STILL open ??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants