Added feature to spawn conptyshell inside tmux session #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thy-GoD
changed the title
|
Exactly what I wanted 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a very small addition to the conptyshell code that allows a user to spawn the whole conptyshell thing in a another tmux pane instead.
This way, it completely removes the requirement of needing gnome-terminal and allows for more flexibility.
I might be able to figure out a way to implement this into the Linux rev shells to allow for shell upgrades.
Hope this helps.
(I am still learning and this may not be optimized code, it checks if we are inside a tmux session by checking if the
tmuxenvironment variable exists or not.)