-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overshoot compensation #140
Open
kev300
wants to merge
10
commits into
syssi:main
Choose a base branch
from
kev300:overshoot_compensation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kev300
force-pushed
the
overshoot_compensation
branch
from
June 15, 2023 14:46
06bc805
to
c36c9ee
Compare
kev300
force-pushed
the
overshoot_compensation
branch
3 times, most recently
from
June 30, 2023 11:18
e2e63b9
to
cb10f0e
Compare
kev300
force-pushed
the
overshoot_compensation
branch
from
December 20, 2023 14:14
2b26c5f
to
402a2d3
Compare
There is a typo in |
kev300
force-pushed
the
overshoot_compensation
branch
from
February 20, 2024 09:15
0c9071c
to
65d86ea
Compare
kev300
force-pushed
the
overshoot_compensation
branch
from
August 29, 2024 07:21
d67bc48
to
bbf3343
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like #122 but less complicated and works better with ramping consumption changes. :)
Fixes: #73 (for me)
Also there is no pid setting anymore, only max_power_sensor_latency_ms.
It is necessary because the inverter does not exactly hit it's power target (demand +500W actually ends up producing something like +480W) and when multiple loads are changing within the compensation period.
Works for me with an update intervall of 250ms at the moment. Without this PR the demand only jumps between min demand and max demand constantly. 😬