Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode improvements #406

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Dark mode improvements #406

merged 3 commits into from
Nov 9, 2023

Conversation

soullivaneuh
Copy link
Contributor

Description

Details

  • This PR cherry-picks the commits of @MG-5 from Fix auto darkmode is overwritten by light mode #405 that fixes the white mode default override.
  • The second commit (85ca6f1) fix the default white mode delay on first opening before getting the browser settings
  • And the last commit (381f74d) use local storage instead of session storage to ensure the preference is kept on the next opening of the website.

This was referenced Nov 7, 2023
Merged
Closed
Closed
sylhare
sylhare approved these changes Nov 9, 2023
View reviewed changes
Copy link
Owner

@sylhare sylhare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @MG-5 and @soullivaneuh

@sylhare sylhare merged commit f531e82 into sylhare:master Nov 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylhare sylhare sylhare approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the choosen color theme persistent Auto darkmode does not work
3 participants
@soullivaneuh @sylhare @MG-5