Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-line header with HTML tags breaks twitter:description meta tag #398

Closed
nickchen120235 opened this issue Sep 10, 2023 · 1 comment · Fixed by #399
Closed

Multi-line header with HTML tags breaks twitter:description meta tag #398

nickchen120235 opened this issue Sep 10, 2023 · 1 comment · Fixed by #399
Assignees
@sylhare
Labels
bug

Comments

@nickchen120235
Copy link
Contributor

Describe the bug
If header_text is set to multi-line content with HTML tags, the content of twitter:description meta tag will overflow to body.

To Reproduce
Steps to reproduce the behavior:

  1. Set header_text in _config.yml to
header_text: >
  This is the first line
  <div style="color: white">This is the second line</div>
  1. Start the jekyll server
  2. Observe the overflow

Expected behavior
Overflow should not happen

Screenshots
image

image
@nickchen120235 nickchen120235 mentioned this issue Sep 10, 2023
Merged
@sylhare
Copy link
Owner

sylhare commented Sep 11, 2023

Nice thanks, let me check the linked PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylhare sylhare

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the filter to the correct order nickchen120235/Type-on-Strap
2 participants
@sylhare @nickchen120235