Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 11. Licensing #155

Open
wants to merge 17 commits into
base: ja
Choose a base branch
from
Open

Translate 11. Licensing #155

wants to merge 17 commits into from

Conversation

kozo2
Copy link
Collaborator

@kozo2 kozo2 commented Aug 1, 2021

#71 is the issue number.

@joelnitta joelnitta self-requested a review August 2, 2021 06:13
Copy link
Member

@joelnitta joelnitta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please note that words before colons like title: etc should generally not be translated in the PO file (they are translated from an overall list separately).

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
kozo2 and others added 7 commits August 9, 2021 17:02
@kozo2
Copy link
Collaborator Author

kozo2 commented Aug 9, 2021

@joelnitta Thanks for your comment!
I committed all your suggestions.

@joelnitta joelnitta linked an issue Oct 2, 2021 that may be closed by this pull request
@joelnitta joelnitta requested a review from masamiy October 3, 2021 00:36
Copy link
Collaborator

@masamiy masamiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the translation! I made some suggestions. Please have a look.

po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved
po/git-novice.ja.po Outdated Show resolved Hide resolved

# unordered list
#: git-novice/_episodes/11-licensing.md:34
msgid "* Whether you want to address patent rights."
msgstr "* Whether you want to address patent rights."
msgstr "* 特許権に取り組みたいかどうか。"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
msgstr "* 特許権に取り組みたいかどうか。"
msgstr "* 特許権をに取り組みたいかどうか。"

I think "address patent rights" needs more clarity. I logged an issue. As when the issue will be reviewed is unknown, I leave this translation as it is for now.

@kozo2
Copy link
Collaborator Author

kozo2 commented Dec 1, 2021

@masamiy Thank you for your suggestions!
I have committed all your suggestions other than #155 (comment) .
Let me know if I can solve #155 (comment) as well.

@joelnitta
Copy link
Member

As we have no idea when @masamiy's issue will be resolved, I think we should accept the translation as it is now (we can add a linked issue here to remind ourselves to fix it in the future).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translation: git-novice Episode 11
3 participants