added rainbows during pride month #117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leuke-naam
requested changes
Mar 11, 2024
SilasPeters
requested changes
Mar 22, 2024
There was a problem hiding this comment.
This PR has no description. I remember that the activities page would be full of rainbows, but I don't see any rainbows. I locally already set let pride = day.getMonth() == 3, as we are in month 3. What am I doing wrong?
I get this error in the console:
Warning: Can't call setState on a component that is not yet mounted.
SilasPeters
requested changes
Mar 22, 2024
Comment on lines
+67
to
+79
| let day = new Date(); | ||
| let pride = day.getMonth() == 5; | ||
|
|
||
| let className = "activity"; | ||
| if (props.active) { | ||
| className += " active"; | ||
| if (pride) { | ||
| className += " activeRainbow"; | ||
| } | ||
| } | ||
|
|
||
| if (pride) { | ||
| className += " rainbow"; |
There was a problem hiding this comment.
Could you add some comments on what the effects are of applying the classnames? We know, and the code reads fine, but it might help for other people to say something like "If we are in pride month, the activities should gain some rainbow effects or other pride related thigns."
|
I'm going to close this issue for staleness reasons, feel free to reopen this PR if there's updates for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.