Adding a method to delete sets #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonuke
requested changes
Feb 12, 2024
| @@ -279,6 +279,11 @@ def get_triangle_coordinate_mapping(self, compress=False): | |||
| tri_map = {eh: c for eh, c in zip(triangle_handles, conn)} | |||
| return tri_map, coords | |||
|
|
|||
| def delete(self): | |||
| """Delete this group from the DAGMC file.""" | |||
| self.model.mb.delete_entity(self.handle) | |||
There was a problem hiding this comment.
Should we delete the entry in model.groups?
There was a problem hiding this comment.
Ah, sorry for the quick-merge! I think we're okay here though as the dict returned by the model.groups property is generated on-the-fly, so the next time it's accessed the groups should reflect those currently in the model.
Previous dict's generated by this property will become stale after a group is deleted, but that will have to be up to the user to track I'm afraid.
There was a problem hiding this comment.
The quick-merge is only enabled by my too superficial review :) - no worries here, then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should of course be used wisely, but it makes sense to be able to remove sets. For instance, one might want to replace group assignments entirely. This would make it easier to do so.