-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a category property to DAGSet #3
Conversation
The class Volume(DAGSet):
_geom_dimension = 3
_category = 'Volume'
@property
def category(self):
return self._category
@property
def dimension(self):
return self._geom_dimension
@classmethod
def create(cls, model, volume_id=None):
new_set = model.mb.create_meshset()
self.model.mb.tag_set_data(model.category_tag, new_set, cls._catetory)
self.model.mb.tag_set_data(model.category_tag, new_set, cls._geom_dimension)
if volume_id is not None:
...
return cls(model new_set)
... We could then also add some checks in the |
@pshriwise I just implemented your suggestion there. Right now, a mismatched |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more tiny request here, but then I think this is ready to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paulromano!
Short PR here adding a
category
property to theDAGSet
class as well as adding a setter for the existinggeom_dimension
property.