Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix]: add test case with darwin OS #1856
[fix]: add test case with darwin OS #1856
Changes from all commits
1939d82
19b8a94
7c374a2
5576287
cb73095
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Kepler won't run on osx, so IMHO, we shouldn't spend time on it. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
well, just because I am a mac user.
as a mac user, when I notice/make some nit fix.
I want to test those locally.
so, I made some build tag on files to make it happen.
any other suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am completely fine with supporting darwin as long as we don't block it in CI as OSX isn't a supported platform.
I also feel it is best to focus on linux as the platform kepler support and hence all development on OSX is expected to use linux box (lima may work well)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep, I agree currently darwin is not major platform to run kepler.
so, @sthaha , can we make an agreement as following:
as instance, this PR, increasing test coverage on config package(benefits), with parts as compilable on darwin.