set recurrence_id based on event _id #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
so we can detect in NH which event is the first one in the series CPCN-695
MarkLark86
reviewed
Mar 21, 2024
| @@ -223,7 +223,7 @@ def on_create(self, docs): | |||
| recurring_events = generate_recurring_events(event) | |||
| generated_events.extend(recurring_events) | |||
| # remove the event that contains the recurring rule. We don't need it anymore | |||
| docs.remove(event) | |||
| docs.remove(event) # todo: why we remove that event and not update it? | |||
There was a problem hiding this comment.
I think we can fix this by skipping the first event inside generate_recurring_events function, that way the passed in Event will not need to be removed.
There was a problem hiding this comment.
I see, will avoid further changes at this stage but might fix it later
MarkLark86
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
so we can later check which event is the initial one
CPCN-695